Do not suppress OSError when constructing Windows named pipes in test fixtures
Marco Ricci

Marco Ricci commited on 2025-12-27 18:52:29
Zeige 1 geänderte Dateien mit 2 Einfügungen und 2 Löschungen.


Let any OSError that occurs when opening the named pipe bubble to the
top of the test fixture, instead of suppressing it and indicating that
the named pipe is unavailable.  At the top level, the test fixture can
then incorporate the error text into the failure or skip message (which
would otherwise be invisible if suppressed further down).
... ...
@@ -348,7 +348,7 @@ def interface_pageant_on_the_annoying_os(
348 348
     del executable, env
349 349
     try:
350 350
         return socketprovider.SocketProvider.windows_named_pipe_for_pageant()
351
-    except (OSError, socketprovider.WindowsNamedPipesNotAvailableError):
351
+    except socketprovider.WindowsNamedPipesNotAvailableError:
352 352
         return None
353 353
 
354 354
 
... ...
@@ -373,7 +373,7 @@ def interface_openssh_agent_on_the_annoying_os(
373 373
     del executable, env
374 374
     try:
375 375
         return socketprovider.SocketProvider.windows_named_pipe_for_openssh()
376
-    except (OSError, socketprovider.WindowsNamedPipesNotAvailableError):
376
+    except socketprovider.WindowsNamedPipesNotAvailableError:
377 377
         return None
378 378
 
379 379
 
380 380