Fix coverage slipup of socket provider alias registration
Marco Ricci

Marco Ricci commited on 2026-01-18 14:25:44
Zeige 1 geänderte Dateien mit 2 Einfügungen und 2 Löschungen.


When registering auto-detected new socket providers, registration should
fail if two different providers try to register the same alias.

The test suite originally contained a test case for this, but it used
the "posix" and "the_annoying_os" names as base names, which were
changed to aliases in 41029a5e6ef04a9870dcaf044b54a26af94260ab.  Thus,
the test *actually* attempted to register something that was previously
an alias as a new base name.  This was also an error (still is), and it
used the same error message, so the test continued to pass.  But it was
then exercising a different code branch, and thus the original code
branch was effectively lacking a dedicated test.

We fix this by resolving the now-aliased entry to its actual base name.
... ...
@@ -393,8 +393,8 @@ is already registered with a different callable.
393 393
 """
394 394
 
395 395
 faulty_entry_alias_exists = _types.SSHAgentSocketProviderEntry(
396
-    socketprovider.SocketProvider.resolve("posix"),
397
-    "posix",
396
+    socketprovider.SocketProvider.resolve("ssh_auth_sock_on_posix"),
397
+    "ssh_auth_sock_on_posix",
398 398
     ("unix_domain", "the_annoying_os"),
399 399
 )
400 400
 """
401 401