Fix minor message deviations in the source tree and phrasing in the manpages
Marco Ricci

Marco Ricci commited on 2025-02-09 20:58:40
Zeige 5 geänderte Dateien mit 19 Einfügungen und 21 Löschungen.

... ...
@@ -122,6 +122,8 @@ The <var>SERVICE</var> is mandatory for `--notes` and `--delete`, optional for `
122 122
 
123 123
 The storage management options deal with importing and exporting the stored settings.
124 124
 They are mutually exclusive; you may only specify one of them.
125
+The <var>SERVICE</var> argument is forbidden.
126
+
125 127
 Using `-` as <var>PATH</var> for standard input/standard output is supported.
126 128
 
127 129
 <b>-e</b> <var>PATH</var>, <b>-</b><b>-export</b> <var>PATH</var>
... ...
@@ -41,14 +41,7 @@
41 41
 .Ar SERVICE
42 42
 .
43 43
 .Nm derivepassphrase vault
44
-.Bro
45
-.Fl \-delete
46
-.Ar SERVICE
47
-|
48
-.Fl \-delete\-globals
49
-|
50
-.Fl \-clear
51
-.Brc
44
+.Brq Fl \-delete Ar SERVICE | Fl \-delete\-globals | Fl \-clear
52 45
 .
53 46
 .Nm derivepassphrase vault
54 47
 .Op Fl \-export\-as Brq Li json | sh
... ...
@@ -321,6 +314,12 @@ Delete all stored settings.
321 314
 The storage management options deal with importing and exporting the stored
322 315
 settings.
323 316
 They are mutually exclusive; you may only specify one of them.
317
+The
318
+.Ar SERVICE
319
+argument is forbidden.
320
+.
321
+.Pp
322
+.
324 323
 Using
325 324
 .Li \-
326 325
 as
... ...
@@ -636,15 +636,11 @@ def check_for_misleading_passphrase(
636 636
         phrase = value['phrase']
637 637
         if not unicodedata.is_normalized(form, phrase):
638 638
             logger.warning(
639
-                (
640
-                    'The %s passphrase is not %s-normalized.  Its '
641
-                    'serialization as a byte string may not be what you '
642
-                    'expect it to be, even if it *displays* correctly.  '
643
-                    'Please make sure to double-check any derived '
644
-                    'passphrases for unexpected results.'
639
+                _msg.TranslatedString(
640
+                    _msg.WarnMsgTemplate.PASSPHRASE_NOT_NORMALIZED,
641
+                    key=formatted_key,
642
+                    form=form,
645 643
                 ),
646
-                formatted_key,
647
-                form,
648 644
                 stacklevel=2,
649 645
                 extra={'color': ctx.color if ctx is not None else None},
650 646
             )
... ...
@@ -1791,8 +1791,9 @@ class WarnMsgTemplate(enum.Enum):
1791 1791
     )(
1792 1792
         'Warning message',
1793 1793
         'An empty {service_metavar!s} is not supported by vault(1).  '
1794
-        'For compatibility, this will be treated as if SERVICE was not '
1795
-        'supplied, i.e., it will error out, or operate on global settings.',
1794
+        'For compatibility, this will be treated as if '
1795
+        '{service_metavar!s} was not supplied, i.e., it will error out, '
1796
+        'or operate on global settings.',
1796 1797
         flags='python-brace-format',
1797 1798
     )
1798 1799
     """"""
... ...
@@ -2031,7 +2032,7 @@ class ErrMsgTemplate(enum.Enum):
2031 2032
     )(
2032 2033
         'Error message',
2033 2034
         "Cannot understand the SSH agent's response because it "
2034
-        'violates the communications protocol.',
2035
+        'violates the communication protocol.',
2035 2036
     )
2036 2037
     """"""
2037 2038
     CANNOT_UPDATE_SETTINGS_NO_SETTINGS = commented(
... ...
@@ -3441,7 +3441,7 @@ class TestCLI:
3441 3441
             )
3442 3442
         result = tests.ReadableResult.parse(result_)
3443 3443
         assert result.error_exit(
3444
-            error='violates the communications protocol.'
3444
+            error='violates the communication protocol.'
3445 3445
         ), 'expected error exit and known error message'
3446 3446
 
3447 3447
     def test_225i_store_config_fail_manual_ssh_agent_refuses(
... ...
@@ -4583,7 +4583,7 @@ Boo.
4583 4583
             with monkeypatch.context() as mp:
4584 4584
                 mp.setattr(ssh_agent.SSHAgentClient, 'sign', fail_runtime)
4585 4585
                 with pytest.raises(
4586
-                    ErrCallback, match='violates the communications protocol'
4586
+                    ErrCallback, match='violates the communication protocol'
4587 4587
                 ):
4588 4588
                     cli_helpers.key_to_phrase(loaded_key, error_callback=err)
4589 4589
 
4590 4590