Annotate all boolean parametrization with sensible test IDs
Marco Ricci commited on 2025-08-15 17:59:56
Zeige 2 geänderte Dateien mit 11 Einfügungen und 3 Löschungen.
Because the boolean value would otherwise become part of the `pytest` test ID, and because the value is devoid of any context, give each boolean parametrization an explicit, hopefully sensible test ID.
- tests/test_derivepassphrase_cli/test_000_basic.py fb4163a..c695ef9
- tests/test_derivepassphrase_cli/test_all_cli.py c9ca081..b153877
| ... | ... |
@@ -700,7 +700,9 @@ class Parametrize(types.SimpleNamespace): |
| 700 | 700 |
], |
| 701 | 701 |
) |
| 702 | 702 |
TRY_RACE_FREE_IMPLEMENTATION = pytest.mark.parametrize( |
| 703 |
- "try_race_free_implementation", [True, False] |
|
| 703 |
+ "try_race_free_implementation", |
|
| 704 |
+ [False, True], |
|
| 705 |
+ ids=["racy", "maybe-race-free"], |
|
| 704 | 706 |
) |
| 705 | 707 |
|
| 706 | 708 |
|
| ... | ... |
@@ -124,8 +124,14 @@ class Parametrize(types.SimpleNamespace): |
| 124 | 124 |
[False, True], |
| 125 | 125 |
ids=["notty", "tty"], |
| 126 | 126 |
) |
| 127 |
- MASK_PROG_NAME = pytest.mark.parametrize("mask_prog_name", [False, True])
|
|
| 128 |
- MASK_VERSION = pytest.mark.parametrize("mask_version", [False, True])
|
|
| 127 |
+ MASK_PROG_NAME = pytest.mark.parametrize( |
|
| 128 |
+ "mask_prog_name", |
|
| 129 |
+ [False, True], |
|
| 130 |
+ ids=["clear_prog_name", "masked_prog_name"], |
|
| 131 |
+ ) |
|
| 132 |
+ MASK_VERSION = pytest.mark.parametrize( |
|
| 133 |
+ "mask_version", [False, True], ids=["clear_version", "masked_version"] |
|
| 134 |
+ ) |
|
| 129 | 135 |
VERSION_OUTPUT_DATA = pytest.mark.parametrize( |
| 130 | 136 |
["version_output", "prog_name", "version", "expected_parse"], |
| 131 | 137 |
[ |
| 132 | 138 |