Recent commits to derivepassphrase.git (2b5f666c4181f5bf899f3b1712febc2a627ea161)

Do not suppress OSError when constructing Windows named pipes in test fixtures

2025-12-27T18:52:29+01:00

Let any OSError that occurs when opening the named pipe bubble to the
top of the test fixture, instead of suppressing it and indicating that
the named pipe is unavailable.  At the top level, the test fixture can
then incorporate the error text into the failure or skip message (which
would otherwise be invisible if suppressed further down).
</pre>

In the test suite, correctly calculate if an SSH agent is isolated

2025-12-27T18:42:06+01:00

In particular, pay consideration to interfaced agents, not just spawned ones.
</pre>

Fix recognition of Pageant in the test fixtures

2025-12-27T18:26:50+01:00

When reacting to failures uploading a test key into an agent, both the
agent type `KnownSSHAgent.UNIXPageant` and the type
`KnownSSHAgent.Pageant` should be treated the same.  However, the
`ssh_agent_client_with_loaded_test_keys` only treated the former agent
type specially.  Now it also treats the latter type the same.
</pre>

Unload loaded test keys in the fixture more efficiently

2025-12-27T17:33:06+01:00

Instead of iterating over all test keys and testing whether the agent is
not isolated and the key is a successfully loaded key, first check
whether the agent is isolated or not, *then* iterate over the
successfully loaded key names and extract the relevant test key from the
test key table.  The efficiency per operation is similar, but the
previous setup always iterated the whole test key table unconditionally,
whereas the new setup only iterates the successfully loaded key name set
(fewer entries than the test key table), and only conditionally.
</pre>

Document the "test key uploading" helper functions

2025-12-27T17:19:38+01:00

Add docstrings to the `_prepare_payload` and `_load_key_optimistically`
helper functions.

Also change the signature of `_load_key_optimistically` to take the test
key structure directly, instead of taking a (dict) key to lookup the
structure.  (These types of things become apparent when writing
docstrings, even for otherwise internal functions.)
</pre>

Auto-format the "test key uploading" fixture and helper functions, again

2025-12-27T17:10:07+01:00

</pre>

Convert the helper function `_load_keys_optimistically` into a per-key function

2025-12-27T17:01:22+01:00

The function is now called `_load_key_optimistically`, and returns a
success indication whether the key was (potentially already) loaded or
not.  Also, the private key blob cannot be `None` anymore, so the
function no longer has degenerate cases.
</pre>

Auto-format the "test key uploading" fixture and helper functions

2025-12-27T15:15:35+01:00

</pre>

Split the "test key loading" fixture function

2025-12-27T15:09:33+01:00

Extract the `_prepare_payload` and the `_load_keys_optimistically`
helper functions from the `ssh_agent_client_with_test_keys_loaded`
fixture function.

The `_load_keys_optimistically` helper function needs further
refactoring into a per-key function, not a per-keyset function; to be
added in a following commit.
</pre>

Prepare the splitting of the "test key loading" fixture function

2025-12-27T14:57:17+01:00

The `ssh_agent_client_with_test_keys_loaded` fixture function is due to
be split, moving the upload bits and the `prepare_payload` function to
new top-level helper functions.  Rename the `prepare_payload` function,
and add parameter definitions so that the extracted functions will make
immediate sense.
</pre>