https://git.schokokeks.org/derivepassphrase.git/tree/4880384a6daf204c5e36dc9467129602099de982Recent commits to derivepassphrase.git (4880384a6daf204c5e36dc9467129602099de982)2025-12-13T15:57:40+01:00tag:gitlist.org,2012:commit/4880384a6daf204c5e36dc9467129602099de982Merge topic branch 'fix-key_to_phrase-missing-callback' into master2025-12-13T15:57:40+01:00Marco Riccisoftware@the13thletter.info
<pre>* fix-key_to_phrase-missing-callback:
Add changelog entry for the `key_to_phrase` missing callback argument fix
Add missing `warning_callback` argument to `key_to_phrase` call
</pre>
tag:gitlist.org,2012:commit/eeaf964acf1c64649c26b0a1b46f422d90a7025dAdd changelog entry for the `key_to_phrase` missing callback argument fix2025-12-13T15:56:49+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>
tag:gitlist.org,2012:commit/79d06d839d033c327f58b965f7413ee151324886Add missing `warning_callback` argument to `key_to_phrase` call2025-12-13T15:47:45+01:00Marco Riccisoftware@the13thletter.info
<pre>The callback parameters in `cli_helpers.key_to_phrase` for handling
warning and error messages are now mandatory to specify. All calls in
production code and in test code(!) now explicitly handle warnings and
errors.
Since changing `cli_helpers.key_to_phrase` in
2413d9dc10ede315c295ab7520a19b21d597a668 to support exception groups,
the function takes additional callback parameters to do its warning and
error handling/reporting. For compatibility reasons, the signature
included default values which suppressed warning messages and exited the
process on error messages.
However, these default values made it too
easy to *forget* proper handling of warning and error messages in the
new implementation. In particular, two call sites in production code,
just several lines apart, had differing warning handling, and the test
suite had two major areas where warning handling was completely absent,
relying on the "suppressed warning messages" default. All these
behaviors were unwanted and wrong, but difficult to spot, because the
test code too was wrong. By making the error and warning handling
callbacks mandatory to specify and removing the implicit suppression
behavior, inadvertent suppression of warning and error messages becomes
much more difficult.
To further ensure this doesn't happen again accidentally, the tests now
also assert that certain expected warning messages are emitted, i.e.,
that the callback is actually exercised.
</pre>
tag:gitlist.org,2012:commit/f3e8f02ae7ead012f3054d0cfb8d7450ee6c8728Merge topic branch 'modularize-and-refactor-test-machinery' into master2025-11-30T15:06:57+01:00Marco Riccisoftware@the13thletter.info
<pre>* modularize-and-refactor-test-machinery: (40 commits)
Move the tests for the stubbed SSH agent socket to the machinery tests
Add module docstrings for the tests hierarchy.
Add a changelog entry for the test suite refactoring
Format and lint all files
Fix type errors due to click 8.2.0
Fix typing of the dummy vault configuration settings in the constructor
Add CPython 3.14 to the list of test environments
Fix more broken tests on The Annoying OS
Fix broken links in the documentation caused by renaming or splitting modules
Split the basic command-line tests, again
Fix missing documentation in the test suite
Fix some documentation issues with the heavy-duty command-line inteface tests
Refactor the heavy-duty command-line interface tests
Refactor the "all CLIs" command-line interface tests
Refactor the basic command-line interface tests
Fix miscellaneous imports, types and hyperlinks in the CLI machinery and tests
Refactor the testing machinery tests
Refactor the SSH agent tests
Refactor the `exporter` tests
Refactor the `vault` and `sequin` tests
...
</pre>
tag:gitlist.org,2012:commit/e737a9ebaaf48e2b741791cc730b36ca30b7bbf2Move the tests for the stubbed SSH agent socket to the machinery tests2025-11-30T14:23:54+01:00Marco Riccisoftware@the13thletter.info
<pre>Even though the stubbed SSH agent socket exists to test the
`derivepassphrase.ssh_agent` module, it is still a piece of testing
machinery at its core, and thus belongs in the same place as the other
testing machinery tests belong. Additionally, although the "basic"
tests for the `derivepassphrase.ssh_agent` module are already a giant
mixed bag of non-heavy-duty tests that all involve functionality from
the `derivepassphrase.ssh_agent` module, the stubbed SSH agent socket
tests differ from the other tests insofar as the other tests focus on
establishing correctness of the `derivepassphrase.ssh_agent` machinery,
whereas the stubbed SSH agent socket tests focus on the stubbed SSH
agent socket. This, too, suggests that the stubbed SSH agent socket
tests do not belong in the same test module as the
`derivepassphrase.ssh_agent` tests.
</pre>
tag:gitlist.org,2012:commit/0a0ba0a96164e824353bf55aecdf64a013133af5Add module docstrings for the tests hierarchy.2025-11-30T13:54:36+01:00Marco Riccisoftware@the13thletter.info
<pre>Consistently add docstrings to all modules in the tests hierarchy that
would appear in the (developer setup) documentation.
</pre>
tag:gitlist.org,2012:commit/e5052d22d115ddfb1bc192ac285000356d9b1e00Merge topic branch 'ssh-agent-socket-providers' into master2025-11-30T10:44:57+01:00Marco Riccisoftware@the13thletter.info
<pre>* ssh-agent-socket-providers:
Add a changelog entry for the NO_AF_UNIX error change
Update the documentation for the reworked NO_AF_UNIX message
Ignore unknown marked messages in the manpage diagnostics
</pre>
tag:gitlist.org,2012:commit/1b28d2bbd1e2311acceed1ded03bc0f35ff13631Add a changelog entry for the NO_AF_UNIX error change2025-11-30T10:44:06+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>
tag:gitlist.org,2012:commit/ce767c9cb2be4111d136bd3846895d237ce4ff03Add a changelog entry for the test suite refactoring2025-11-30T10:08:07+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>
tag:gitlist.org,2012:commit/eec18c81f32f558435e222848d8cd1688b4ae26eFormat and lint all files2025-11-30T09:35:38+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>