Recent commits to derivepassphrase.git (55547619b270f05ebef7934129532dab9b1a3af5)

Use a better test for no-op editing notes

2025-02-04T13:17:03+01:00

"no-op" editing of notes makes no sense for a service which does not
have notes yet.  Also, "no-op" editing may involve extra whitespace at
the beginning or end of the contents.  Use these two facts to construct
a better test.

Also, do not use click's convenience feature of using a `None` return to
signal that no changes have been made.  The check is heuristic in nature
(it involves filesystem timestamps), and vault(1) actually uses a more
naive system that does not map cleanly to click's system.
</pre>

Partially align notes printing and editing behavior with vault(1)

2025-02-04T13:16:29+01:00

Notes (if any) are printed after the derived passphrase is emitted.  The
`--notes` flag is an option, not a command: editing notes requires both
`--notes` and `--config`.  Any such edits happen after querying for
master passphrases or SSH keys to use.

Editing notes, even if a no-op, will at least register the service name
as a known service.

The `--unset` option now additionally accepts the "notes" argument.

(Caveat: vault(1) actually leaves the terminal in a bad state during
editing if called after querying a master passphrase or selecting an SSH
key.)
</pre>

Assert that notes should be printed (via xfailing test)

2025-02-04T09:53:14+01:00

Like vault(1), `derivepassphrase vault` should print the service's notes
to standard error when deriving a passphrase.  But due to an oversight,
it currently doesn't.  Explicitly test for this.
</pre>

Merge topic branch 'usage-fixes' into master

2025-02-02T15:32:18+01:00

* t/usage-fixes:
  Reorder parametrizations with modified argument lists
  Implement all parametrization-related changes suggested in the TODOs
  Convert Parametrizations enums to Parametrize namespace
  Consolidate test parametrizations per test module
  Resolve dependency versions explicitly in pyproject.toml
  Fix inconsistent indentation in pyproject.toml
  Add static analysis and testing dependencies to "dev" extra
  Remove type annotations from enum value definitions
  Fix formatting nitpicks from ruff
  Document general changes to the test suite since 0.4.0
  Document change in testing setup
  Adjust hypothesis deadlines globally and redo the profiles and slowdown factors
</pre>

Reorder parametrizations with modified argument lists

2025-02-02T13:39:03+01:00

</pre>

Implement all parametrization-related changes suggested in the TODOs

2025-02-02T11:55:25+01:00

Most of these are straight-forward cases of renaming, consolidating, or
yielding additional parameters.

Regarding the TODOs in the `ssh_agent` test module dealing with `skip`
and `xfail` messages, I decided to follow [Paul Ganssle's use of
`xfail`][GANSSLE_XFAIL]: "use `skip` for tests that *aren't supposed to
work*", and "use `xfail` for tests that *should, but currently don't
pass*".  (In other words, for `skip`, the failure is external to the
system under test and cannot be accomodated for; for `xfail`, it is
internal, or part of the system under test's job to accomodate for it.)
For the aforementioned tests for the `ssh_agent` module, both `skip`
messages occur because of unsatisfied assumptions on the running SSH
agent (a test key isn't loaded, or one kind of failure mode doesn't
occur with this agent), so they shall both remain `skip` messages.

[GANSSLE_XFAIL]: https://blog.ganssle.io/articles/2021/11/pytest-xfail.html
</pre>

Convert Parametrizations enums to Parametrize namespace

2025-02-01T23:25:35+01:00

Switch out `enum.Enum` for `types.SimpleNamespace` to collect the
various `pytest.mark.parametrize` decorators: it works equally well in
practice when coupled with a type checker, and it avoids having to
unpack the enum value when actually calling the decorator.  Opt for the
shorter name `Parametrize` instead of `Parametrizations`.

Also consolidate the two versions of the `VAULT_CONFIG_FORMATS_DATA`
parametrization set by moving it into a dedicated namespace in the
top-level `tests` package.
</pre>

Consolidate test parametrizations per test module

2025-02-01T15:55:49+01:00

Collect all calls to `pytest.mark.parametrize` in a per-module enum.
This deduplicates the definitions and highlights inconsistencies.

(For the CLI test module, the shell formatter functions were moved above
the enum to avoid NameErrors.)
</pre>

Resolve dependency versions explicitly in pyproject.toml

2025-01-31T18:03:02+01:00

Remove the `~=` version specifiers in favor of `>=` specifiers, and only
use explicitly tested versions as minimum version requirements.

Also explicitly list pytest plugins and coverage plugins as
dependencies.
</pre>

Fix inconsistent indentation in pyproject.toml

2025-01-31T15:37:32+01:00

</pre>