Recent commits to derivepassphrase.git (5bb568dd3fa3c5754132caa39cf57b3d13935048)

Add links and anchors for version/upgrade information and changelog sections

2025-01-23T10:53:54+01:00

Add separate documentation pages for Python version information and
`derivepassphrase` upgrade notes.  Apart from the informative aspect, it
also serves as an anchor which all code upgrade tasks and TODOs that
belong to the same upgrade step can link to, and which can then be
grepped for in the code.

Relatedly, give the changelog proper, systematic, non-auto-generated
anchor targets.
</pre>

Merge topic branch 'usage-fixes' into master

2025-01-23T10:52:16+01:00

* t/usage-fixes:
  Move license in docstring to comments
  Refactor some if/elif/else-towers into dispatch tables
  Make the notes instruction text and marker translatable
</pre>

Move license in docstring to comments

2025-01-23T10:51:36+01:00

</pre>

Refactor some if/elif/else-towers into dispatch tables

2025-01-23T10:51:36+01:00

</pre>

Make the notes instruction text and marker translatable

2025-01-23T10:51:36+01:00

The instruction text for editing notes is natural language text, and
should therefore be translated, but was overlooked when determining
translatable messages.

To ensure that the instruction text and the marker cannot be mismatched,
the marker is translated separately and inserted verbatim after the
instruction text.
</pre>

Merge topic branch 'code-cleanup' into master

2025-01-22T16:46:06+01:00

* t/code-cleanup:
  Fix improper use of `assert_never`
  Fix outdated test config specification
  Refactor pytest fixtures concerning SSH agent spawning
  Refactor vault config validity checking and falsy value cleanup functions
  Check at runtime if deprecated keyword arguments are used
</pre>

Fix improper use of `assert_never`

2025-01-21T21:02:31+01:00

</pre>

Fix outdated test config specification

2025-01-21T21:02:31+01:00

The set of "consistently testable vault configurations" is determined by
a specific settings to the validator function.  The validator function
no longer accepts the `allow_derivepassphrase_extensions` keyword
parameter, but the vault test config selection logic was not yet updated
to reflect this.
</pre>

Refactor pytest fixtures concerning SSH agent spawning

2025-01-21T21:02:31+01:00

The two pytest fixtures `running_ssh_agent` and `spawn_ssh_agent` both
deal with providing access to SSH agents, spawning them if necessary.
They differ in the data they provide to the test functions (just the
environment setup, or an actual connected `SSHAgentClient`) and in their
parametrization (`running_ssh_agent` spawns any one, `spawn_ssh_agent`
spawns all).  However, despite the spawning logic being basically
identical, both methods contained incompatible implementations of the
logic, separately for named agent spawning and for system agent
spawning.

So, consolidate these functions into a single spawning function, and
move all necessary supporting code (context manager for subprocess
termination, typing protocol for spawn function) to the top level.
</pre>

Refactor vault config validity checking and falsy value cleanup functions

2025-01-21T21:02:31+01:00

Introduce a new workhorse class that provides the validity checking and
the falsy value cleanup functionality.  The existing top-level functions
are now mere facades.  The primary reason is to keep the complexity and
the nesting level of these functions low-ish: they still trigger linting
errors that need to be silenced, but the nesting is tamer, and some
common functionality (e.g., tree traversal) can be usefully extracted.
</pre>