Recent commits to derivepassphrase.git (61fbc909d899ac2bd791b14c20987553b638ac4f)

Reintroduce a "modern" editor interface à la git-commit or git-rebase

2025-02-06T14:27:21+01:00

Reintroduce the previous git-like editor interface as the "modern"
editor interface to the "vault" subcommand, and provide explicit options
`--modern-editor-interface` and `--vault-legacy-editor-interface`,
defaulting to the latter for compatibility.

Furthermore, for the legacy interface, introduce a backup copy of the
notes to guard against accidental data loss, because the legacy
interface offers no way to abort mid-editing, making fatal mistakes all
the more likely.
</pre>

Warn the user when `derivepassphrase vault --notes` is ineffective

2025-02-06T13:16:37+01:00

In 7b0f4e121a5e688b59abad73b8b60bacfc7d02ed, we adjusted
`derivepassphrase` to only act upon `--notes` if `--config` is also
given, for compatibility with vault(1).  However, this is incompatible
with previous versions of `derivepassphrase`, and potentially confusing
even to vault(1) users.  As such, `derivepassphrase vault` now emits
a warning if it is called with `--notes` but without `--config`.
</pre>

Use a vault(1)-compatible naive notes editing system

2025-02-05T14:44:16+01:00

We originally provided a modern git-like editor interface, with a marker
for explanatory texts and with support for aborting the edit by leaving
the file empty.  vault(1) however takes the contents of the notes file
literally.  For compatibility, we must do the same.
</pre>

Use hypothesis for notes handling tests

2025-02-05T14:40:56+01:00

Have the existing or the new notes be generated data (whichever is
appropriate).

Also handle the previously untested case of aborting the notes edit when
there are no stored notes yet.  *This* test does not use hypothesis.
</pre>

Adapt notes printing test to arbitrary notes

2025-02-05T12:07:24+01:00

</pre>

Clean up notes testing functions

2025-02-04T13:30:22+01:00

They had similar bad defaults and easily avoidable linting overrides
like the no-op test.
</pre>

Use a better test for no-op editing notes

2025-02-04T13:17:03+01:00

"no-op" editing of notes makes no sense for a service which does not
have notes yet.  Also, "no-op" editing may involve extra whitespace at
the beginning or end of the contents.  Use these two facts to construct
a better test.

Also, do not use click's convenience feature of using a `None` return to
signal that no changes have been made.  The check is heuristic in nature
(it involves filesystem timestamps), and vault(1) actually uses a more
naive system that does not map cleanly to click's system.
</pre>

Partially align notes printing and editing behavior with vault(1)

2025-02-04T13:16:29+01:00

Notes (if any) are printed after the derived passphrase is emitted.  The
`--notes` flag is an option, not a command: editing notes requires both
`--notes` and `--config`.  Any such edits happen after querying for
master passphrases or SSH keys to use.

Editing notes, even if a no-op, will at least register the service name
as a known service.

The `--unset` option now additionally accepts the "notes" argument.

(Caveat: vault(1) actually leaves the terminal in a bad state during
editing if called after querying a master passphrase or selecting an SSH
key.)
</pre>

Assert that notes should be printed (via xfailing test)

2025-02-04T09:53:14+01:00

Like vault(1), `derivepassphrase vault` should print the service's notes
to standard error when deriving a passphrase.  But due to an oversight,
it currently doesn't.  Explicitly test for this.
</pre>

Merge topic branch 'usage-fixes' into master

2025-02-02T15:32:18+01:00

* t/usage-fixes:
  Reorder parametrizations with modified argument lists
  Implement all parametrization-related changes suggested in the TODOs
  Convert Parametrizations enums to Parametrize namespace
  Consolidate test parametrizations per test module
  Resolve dependency versions explicitly in pyproject.toml
  Fix inconsistent indentation in pyproject.toml
  Add static analysis and testing dependencies to "dev" extra
  Remove type annotations from enum value definitions
  Fix formatting nitpicks from ruff
  Document general changes to the test suite since 0.4.0
  Document change in testing setup
  Adjust hypothesis deadlines globally and redo the profiles and slowdown factors
</pre>