https://git.schokokeks.org/derivepassphrase.git/tree/64c0b5259347546e33259889bc75e094ed6b44f7 Recent commits feed provided by GitList. https://git.schokokeks.org/derivepassphrase.git/commit/64c0b5259347546e33259889bc75e094ed6b44f7 software@the13thletter.info (Marco Ricci) Thu, 23 Jan 2025 10:51:36 +0100 64c0b5259347546e33259889bc75e094ed6b44f7 The instruction text for editing notes is natural language text, and should therefore be translated, but was overlooked when determining translatable messages. To ensure that the instruction text and the marker cannot be mismatched, the marker is translated separately and inserted verbatim after the instruction text. https://git.schokokeks.org/derivepassphrase.git/commit/de8a116ceb0a86a13c38266088eedb5f53713d91 software@the13thletter.info (Marco Ricci) Thu, 23 Jan 2025 10:51:36 +0100 de8a116ceb0a86a13c38266088eedb5f53713d91 * t/code-cleanup: Fix improper use of `assert_never` Fix outdated test config specification Refactor pytest fixtures concerning SSH agent spawning Refactor vault config validity checking and falsy value cleanup functions Check at runtime if deprecated keyword arguments are used https://git.schokokeks.org/derivepassphrase.git/commit/6d9d005af10253c3ebdc4f6b2bda3d196fb739bb software@the13thletter.info (Marco Ricci) Wed, 22 Jan 2025 16:46:06 +0100 6d9d005af10253c3ebdc4f6b2bda3d196fb739bb https://git.schokokeks.org/derivepassphrase.git/commit/4f4a484f760953687ebd96d3bfdc105b10bd2dcf software@the13thletter.info (Marco Ricci) Tue, 21 Jan 2025 21:02:31 +0100 4f4a484f760953687ebd96d3bfdc105b10bd2dcf The set of "consistently testable vault configurations" is determined by a specific settings to the validator function. The validator function no longer accepts the `allow_derivepassphrase_extensions` keyword parameter, but the vault test config selection logic was not yet updated to reflect this. https://git.schokokeks.org/derivepassphrase.git/commit/6360edaffe920cdeae6a661bcf477f8496225212 software@the13thletter.info (Marco Ricci) Tue, 21 Jan 2025 21:02:31 +0100 6360edaffe920cdeae6a661bcf477f8496225212 The two pytest fixtures `running_ssh_agent` and `spawn_ssh_agent` both deal with providing access to SSH agents, spawning them if necessary. They differ in the data they provide to the test functions (just the environment setup, or an actual connected `SSHAgentClient`) and in their parametrization (`running_ssh_agent` spawns any one, `spawn_ssh_agent` spawns all). However, despite the spawning logic being basically identical, both methods contained incompatible implementations of the logic, separately for named agent spawning and for system agent spawning. So, consolidate these functions into a single spawning function, and move all necessary supporting code (context manager for subprocess termination, typing protocol for spawn function) to the top level. https://git.schokokeks.org/derivepassphrase.git/commit/d0d1b6c0c5508419c327dd9e5e0fe3f783757d38 software@the13thletter.info (Marco Ricci) Tue, 21 Jan 2025 21:02:31 +0100 d0d1b6c0c5508419c327dd9e5e0fe3f783757d38 Introduce a new workhorse class that provides the validity checking and the falsy value cleanup functionality. The existing top-level functions are now mere facades. The primary reason is to keep the complexity and the nesting level of these functions low-ish: they still trigger linting errors that need to be silenced, but the nesting is tamer, and some common functionality (e.g., tree traversal) can be usefully extracted. https://git.schokokeks.org/derivepassphrase.git/commit/2cc4e4fffab112760803e80084f665d87b468069 software@the13thletter.info (Marco Ricci) Tue, 21 Jan 2025 21:02:31 +0100 2cc4e4fffab112760803e80084f665d87b468069 The `warnings.deprecated` decorator sadly does not do anything at runtime if merely one of several overloads is deprecated. And it seems to fail even if the deprecated signature is actively used; see `_types.is_vault_config`. Implement a known working solution to check if the deprecated keyword argument was supplied. (No tests yet, so excluded from coverage.) https://git.schokokeks.org/derivepassphrase.git/commit/387941e06b2539a702c22139d1f7475f30217c62 software@the13thletter.info (Marco Ricci) Tue, 21 Jan 2025 21:02:31 +0100 387941e06b2539a702c22139d1f7475f30217c62 * t/pathlib: Use `pathlib` for path or filename operations https://git.schokokeks.org/derivepassphrase.git/commit/80810bd4eaa1dd9db8434d95682347ae36ce8b07 software@the13thletter.info (Marco Ricci) Mon, 20 Jan 2025 18:00:28 +0100 80810bd4eaa1dd9db8434d95682347ae36ce8b07 The interface was already supported by all the user-facing code (interestingly enough) and by almost all of the internal code. Using `pathlib.Path` objects directly instead of manually dealing with string or byte string collections does cut down on a lot of the otherwise explicit bookkeeping and context management. Some changes to the tests are necessary because other (or more) functions need to be mocked, or other ways of testing successful or ensuring unsuccessful operations are needed. https://git.schokokeks.org/derivepassphrase.git/commit/65725c82b8466edb0c90061e0750a3d9aaa9f53b software@the13thletter.info (Marco Ricci) Mon, 20 Jan 2025 18:00:12 +0100 65725c82b8466edb0c90061e0750a3d9aaa9f53b