Recent commits to derivepassphrase.git (67c0e85e3683710ece9674a480412ba8196e1cc0)

Purge hatch-gettext build plugin, and manually compile translations

2025-03-16T23:59:30+01:00

The hatch-gettext plugin requires Python 3.10 or higher, and
consequently hinders non-wheel installation of derivepassphrase on
Python 3.9 or PyPy 3.9.  The project also is, upon closer inspection,
alpha or beta quality: there are no tests, there appear to be no active
users (no issues or non-author pull requests filed), and the code
contains some dubious constructs (such as assembling all calls to
external programs as command-line strings, then naively splitting them
on whitespace).  I do not want to commit to using this build plugin in
any non-prototype setting.  So remove these settings from the build
system, build the translation message catalogs ourselves, and unignore
the respective paths.
</pre>

Add a German translation

2025-03-16T23:53:16+01:00

Co-authored-by: Isabell Hoffstadt
</pre>

Fix indentation handling in the translation template

2025-03-16T23:50:53+01:00

</pre>

Fix miscellaneous issues with the CLI messages

2025-03-16T23:13:47+01:00

  * The "interactive input" replacement value for the
    `WarnMsgTemplate.PASSPHRASE_NOT_NORMALIZED` message is now
    translatable.  The previous form was quirky and too clever, and
    probably only worked in languages with similar grammar and sentence
    structure.

  * The `Label.DERIVEPASSPHRASE_VAULT_REPEAT_HELP_TEXT` message was
    wrong due to an off-by-one error.

  * The `Label.DERIVEPASSPHRASE_VAULT_PRINT_NOTES_BEFORE_HELP_TEXT`
    message should reference the service metavar, not the term "service"
    itself.

  * The default notes placeholder text when using the vault legacy
    editor interface is very wordy, and incited at least one test user
    to delete it character by character before entering the new notes.
    A shorter placeholder text will hopefully achieve the same effect in
    less keystrokes.

  * Several verb tense and punctuation mistakes were corrected.
</pre>

Update translations template

2025-03-16T13:33:37+01:00

</pre>

Merge topic branch 'vault-cli-objectification' into master

2025-03-16T13:23:38+01:00

* vault-cli-objectification:
  Reimplement the `vault` CLI as methods of a context object
</pre>

Reimplement the `vault` CLI as methods of a context object

2025-03-16T13:23:05+01:00

Introduce a "vault context" object holding the associated data for the
call to the `derivepassphrase vault` CLI, and implement the actual CLI
as a collection of methods on this object.  The "vault context" object
mostly just wraps the click context object and encodes the dispatch
table for the CLI operations.  The main advantage of this modelling is
the much smaller size per, and lower cyclomatic complexity of, each CLI
operation.

As an implementation detail, the old implementation of the
`get_user_config` inner function's error handling branch for `OSError`
had coverage testing purely by accident, because `get_user_config` was
being called unconditionally, very early in the CLI control flow.  The
refactored CLI however reads the user configuration only as needed for
the specific operation. So this error handling branch needs a new,
separate test.

As a further implementation detail, the `is_param_set` inner function no
longer caches its result, because it is now an object method:
`functools.cache` explicitly documents that adding a cache to object
methods causes a circular reference between the cache and the object via
the `self` parameter.  Given the actual contents of this function, there
appears to be little point in working around this memory issue just to
outfit an already cheap operation (a single `Mapping.get` call) with
a cache.

As yet another further implementation detail, checking for misleading
passphrases should work even if the passed configuration snippet is not
technically a `dict`, but rather a `Mapping`.

Finally, due to the vault context object now wrapping the click context,
it is possible (and sensible) to wrap the logging calls into methods of
the vault context object so that less out-of-bounds information needs to
be passed to the logger explicitly at the call site.
</pre>

Merge topic branch 'hatch-test-matrix' into master

2025-03-13T13:32:54+01:00

* hatch-test-matrix:
  Add PyPy 3.11 to the test matrix
</pre>

Add PyPy 3.11 to the test matrix

2025-03-13T13:21:20+01:00

</pre>

Merge topic branch 'concurrency-audit' into master

2025-03-13T13:18:24+01:00

* concurrency-audit:
  Document the results of the concurrency audit
  Lock the derivepassphrase CLI against concurrent updating
  Lock derivepassphrase internals against concurrent updating

GitHub: Closes #22.
</pre>