Recent commits to derivepassphrase.git (79d06d839d033c327f58b965f7413ee151324886)

Add missing `warning_callback` argument to `key_to_phrase` call

2025-12-13T15:47:45+01:00

The callback parameters in `cli_helpers.key_to_phrase` for handling
warning and error messages are now mandatory to specify.  All calls in
production code and in test code(!) now explicitly handle warnings and
errors.

Since changing `cli_helpers.key_to_phrase` in
2413d9dc10ede315c295ab7520a19b21d597a668 to support exception groups,
the function takes additional callback parameters to do its warning and
error handling/reporting.  For compatibility reasons, the signature
included default values which suppressed warning messages and exited the
process on error messages.

However, these default values made it too
easy to *forget* proper handling of warning and error messages in the
new implementation.  In particular, two call sites in production code,
just several lines apart, had differing warning handling, and the test
suite had two major areas where warning handling was completely absent,
relying on the "suppressed warning messages" default.  All these
behaviors were unwanted and wrong, but difficult to spot, because the
test code too was wrong.  By making the error and warning handling
callbacks mandatory to specify and removing the implicit suppression
behavior, inadvertent suppression of warning and error messages becomes
much more difficult.

To further ensure this doesn't happen again accidentally, the tests now
also assert that certain expected warning messages are emitted, i.e.,
that the callback is actually exercised.
</pre>

Merge topic branch 'modularize-and-refactor-test-machinery' into master

2025-11-30T15:06:57+01:00

* modularize-and-refactor-test-machinery: (40 commits)
  Move the tests for the stubbed SSH agent socket to the machinery tests
  Add module docstrings for the tests hierarchy.
  Add a changelog entry for the test suite refactoring
  Format and lint all files
  Fix type errors due to click 8.2.0
  Fix typing of the dummy vault configuration settings in the constructor
  Add CPython 3.14 to the list of test environments
  Fix more broken tests on The Annoying OS
  Fix broken links in the documentation caused by renaming or splitting modules
  Split the basic command-line tests, again
  Fix missing documentation in the test suite
  Fix some documentation issues with the heavy-duty command-line inteface tests
  Refactor the heavy-duty command-line interface tests
  Refactor the "all CLIs" command-line interface tests
  Refactor the basic command-line interface tests
  Fix miscellaneous imports, types and hyperlinks in the CLI machinery and tests
  Refactor the testing machinery tests
  Refactor the SSH agent tests
  Refactor the `exporter` tests
  Refactor the `vault` and `sequin` tests
  ...
</pre>

Move the tests for the stubbed SSH agent socket to the machinery tests

2025-11-30T14:23:54+01:00

Even though the stubbed SSH agent socket exists to test the
`derivepassphrase.ssh_agent` module, it is still a piece of testing
machinery at its core, and thus belongs in the same place as the other
testing machinery tests belong.  Additionally, although the "basic"
tests for the `derivepassphrase.ssh_agent` module are already a giant
mixed bag of non-heavy-duty tests that all involve functionality from
the `derivepassphrase.ssh_agent` module, the stubbed SSH agent socket
tests differ from the other tests insofar as the other tests focus on
establishing correctness of the `derivepassphrase.ssh_agent` machinery,
whereas the stubbed SSH agent socket tests focus on the stubbed SSH
agent socket.  This, too, suggests that the stubbed SSH agent socket
tests do not belong in the same test module as the
`derivepassphrase.ssh_agent` tests.
</pre>

Add module docstrings for the tests hierarchy.

2025-11-30T13:54:36+01:00

Consistently add docstrings to all modules in the tests hierarchy that
would appear in the (developer setup) documentation.
</pre>

Merge topic branch 'ssh-agent-socket-providers' into master

2025-11-30T10:44:57+01:00

* ssh-agent-socket-providers:
  Add a changelog entry for the NO_AF_UNIX error change
  Update the documentation for the reworked NO_AF_UNIX message
  Ignore unknown marked messages in the manpage diagnostics
</pre>

Add a changelog entry for the NO_AF_UNIX error change

2025-11-30T10:44:06+01:00

</pre>

Add a changelog entry for the test suite refactoring

2025-11-30T10:08:07+01:00

</pre>

Format and lint all files

2025-11-30T09:35:38+01:00

</pre>

Fix type errors due to click 8.2.0

2025-11-29T22:35:16+01:00

`click` 8.2.0 broke compatibility in an unexpectingly violent way,
removing previously public symbols without any transition period.  Thus,
the code may or may not type check, depending on which version of
`click` is installed.  We thus disable type checking or otherwise type
check on a more coarse level whereever we used one of the now-removed
symbols.
</pre>

Fix typing of the dummy vault configuration settings in the constructor

2025-11-27T21:59:27+01:00

One of our tests, a "manual sanity-check" kind of test, tries to use the
`tests.data.DUMMY_CONFIG_SETTINGS` symbol as keyword arguments in the
`vault.Vault` constructor.  This appeared to work with older `mypy`
versions, but now raises an error about extra keys in the symbol that
the constructor does not accept as keyword arguments.  (Because the
dummy config settings are actually typed as vault config "services"
settings, which *do* allow more settings than the constructor uses as
arguments.)

So, we now arrange for a second symbol with effectively the same
contents as the dummy config settings, but explicitly typed as
constructor arguments, to be used in the "manual sanity-check" test
instead.

(Implementation-wise, we introduce a new base type
`_types.VaultConstructorArgs`, and let
`_types.VaultConfigServicesSettings` inherit from that.  This is easier
than attempting to constrain the latter type after the fact.  We
introduce the new base type directly in the `_types` module, even though
it is otherwise only used in the tests, because the derived type (from
the `_types` module) also needs access during construction.)
</pre>