Recent commits to derivepassphrase.git (85e34a89c821ee87ab6a9986e21e8001f732c52f)

Specify project dependencies more clearly and explicitly

2024-08-17T01:09:23+02:00

Use proper syntax for dependency version specification (spaces, and
compatible release operator).  If sensible, add a comment as to why we
have this dependency, and why at that version.  Furthermore, for hatch
environments, make use of environment inheritance, and move the
dependencies to the correct environments instead of collecting them all
in the "dev" extra.
</pre>

Sort sections in pyproject.toml

2024-08-17T00:52:02+02:00

</pre>

Merge topic branch 'issue4-improve-common-error-messages' into master

2024-08-16T17:12:56+02:00

* t/issue4-improve-common-error-messages:
  Add Changelog entry for error message/handling revision
  Add missing tests for reworked error message handling
  Fix error message capitalization
  Fix error bubbling in outdated test
  Add a specific error class and codes for SSH agent failures
  Document and handle other errors passed through to the command-line interface
  Use better error message handling in the command-line interface

GitHub: Closes #4.
</pre>

Add Changelog entry for error message/handling revision

2024-08-16T17:12:38+02:00

</pre>

Add missing tests for reworked error message handling

2024-08-16T16:31:24+02:00

Add missing tests for the revised error messages/classes and error
handling code due to a1763e8b5dedbf123856a79ddb0e8395cddd6f88 and
5c6045e10ca9c8b56432711dec5efb98b5892d55.
</pre>

Fix error message capitalization

2024-08-16T16:21:45+02:00

We still use error messages with non-sentence case at multiple places,
particularly messages like "no valid SSH key selected".
</pre>

Fix error bubbling in outdated test

2024-08-16T16:19:56+02:00

In
`tests.test_derivepassphrase_cli:test_230a_config_directory_not_a_file`,
we assumed that a `FileExistsError` while storing the configuration file
would bubble all the way up to the test harness.  This isn't the case
anymore, because of a1763e8b5dedbf123856a79ddb0e8395cddd6f88 and
5c6045e10ca9c8b56432711dec5efb98b5892d55... but we actually forgot to
update the call to use the new wrapper from
5c6045e10ca9c8b56432711dec5efb98b5892d55.
</pre>

Add a specific error class and codes for SSH agent failures

2024-08-16T13:27:20+02:00

Add the generic `SSH_AGENT_FAILURE` and `SSH_AGENT_SUCCESS` status codes
(as `_types.SSH_AGENT.FAILURE` and `_types.SSH_AGENT.SUCCESS`,
respectively), and add an `SSHAgentFailedError` class to signal error
returns from the SSH agent. The error class may emit a specific or
a generic error message, depending on the status code and error message
passed.

Rewrite the tests to use actual failure status codes, instead of random
magic numbers. Rewrite it further to deal with the `_types.SSH_AGENT`
enum instead of numeric codes. This also makes the tests more readable.
</pre>

Document and handle other errors passed through to the command-line interface

2024-08-16T12:48:10+02:00

These errors have already been passed through, but they were neither
documented nor explicitly handled in the command-line interface with an
appropriate error message.
</pre>

Use better error message handling in the command-line interface

2024-08-16T12:38:08+02:00

Instead of blindly relying on `click.Context.fail`, which causes a usage
message to be printed, implement our own error-exit function.

Furthermore, since writing the configuration file is prone to similar
problems as reading it, include a wrapper for writing the configuration
file as well, which ensures errors are properly reported.

Due to the rewrite, some error messages changed slightly in phrasing
and/or in capitalization.
</pre>