https://git.schokokeks.org/derivepassphrase.git/tree/abe57a7e94e54d5c8139e9661b9222000b24b99eRecent commits to derivepassphrase.git (abe57a7e94e54d5c8139e9661b9222000b24b99e)2025-03-16T23:53:16+01:00tag:gitlist.org,2012:commit/abe57a7e94e54d5c8139e9661b9222000b24b99eAdd a German translation2025-03-16T23:53:16+01:00Marco Riccisoftware@the13thletter.info
<pre>Co-authored-by: Isabell Hoffstadt
</pre>
tag:gitlist.org,2012:commit/febfd09916cde8d5e47a26a3cad8a11176d758dbFix indentation handling in the translation template2025-03-16T23:50:53+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>
tag:gitlist.org,2012:commit/b127dd363ce8ad0ad26e88c31200dc5c3736f8b4Fix miscellaneous issues with the CLI messages2025-03-16T23:13:47+01:00Marco Riccisoftware@the13thletter.info
<pre> * The "interactive input" replacement value for the
`WarnMsgTemplate.PASSPHRASE_NOT_NORMALIZED` message is now
translatable. The previous form was quirky and too clever, and
probably only worked in languages with similar grammar and sentence
structure.
* The `Label.DERIVEPASSPHRASE_VAULT_REPEAT_HELP_TEXT` message was
wrong due to an off-by-one error.
* The `Label.DERIVEPASSPHRASE_VAULT_PRINT_NOTES_BEFORE_HELP_TEXT`
message should reference the service metavar, not the term "service"
itself.
* The default notes placeholder text when using the vault legacy
editor interface is very wordy, and incited at least one test user
to delete it character by character before entering the new notes.
A shorter placeholder text will hopefully achieve the same effect in
less keystrokes.
* Several verb tense and punctuation mistakes were corrected.
</pre>
tag:gitlist.org,2012:commit/6372560fd2c27a91c55769659a1748a0cc3ca5d1Update translations template2025-03-16T13:33:37+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>
tag:gitlist.org,2012:commit/cd3c72db9b6457dc6757effa209693ce10dd4dbdMerge topic branch 'vault-cli-objectification' into master2025-03-16T13:23:38+01:00Marco Riccisoftware@the13thletter.info
<pre>* vault-cli-objectification:
Reimplement the `vault` CLI as methods of a context object
</pre>
tag:gitlist.org,2012:commit/7261f505d57249ef54b8c66a30efb57890ba70a7Reimplement the `vault` CLI as methods of a context object2025-03-16T13:23:05+01:00Marco Riccisoftware@the13thletter.info
<pre>Introduce a "vault context" object holding the associated data for the
call to the `derivepassphrase vault` CLI, and implement the actual CLI
as a collection of methods on this object. The "vault context" object
mostly just wraps the click context object and encodes the dispatch
table for the CLI operations. The main advantage of this modelling is
the much smaller size per, and lower cyclomatic complexity of, each CLI
operation.
As an implementation detail, the old implementation of the
`get_user_config` inner function's error handling branch for `OSError`
had coverage testing purely by accident, because `get_user_config` was
being called unconditionally, very early in the CLI control flow. The
refactored CLI however reads the user configuration only as needed for
the specific operation. So this error handling branch needs a new,
separate test.
As a further implementation detail, the `is_param_set` inner function no
longer caches its result, because it is now an object method:
`functools.cache` explicitly documents that adding a cache to object
methods causes a circular reference between the cache and the object via
the `self` parameter. Given the actual contents of this function, there
appears to be little point in working around this memory issue just to
outfit an already cheap operation (a single `Mapping.get` call) with
a cache.
As yet another further implementation detail, checking for misleading
passphrases should work even if the passed configuration snippet is not
technically a `dict`, but rather a `Mapping`.
Finally, due to the vault context object now wrapping the click context,
it is possible (and sensible) to wrap the logging calls into methods of
the vault context object so that less out-of-bounds information needs to
be passed to the logger explicitly at the call site.
</pre>
tag:gitlist.org,2012:commit/47e3b46d01ffffe4a24ec7e73f4c0833fa0e4ca0Merge topic branch 'hatch-test-matrix' into master2025-03-13T13:32:54+01:00Marco Riccisoftware@the13thletter.info
<pre>* hatch-test-matrix:
Add PyPy 3.11 to the test matrix
</pre>
tag:gitlist.org,2012:commit/af40d3b552a6dec8b42833ecc2dfd32c8894f76eAdd PyPy 3.11 to the test matrix2025-03-13T13:21:20+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>
tag:gitlist.org,2012:commit/a4ad05723414662d9df1607034c5dd7d646f1b49Merge topic branch 'concurrency-audit' into master2025-03-13T13:18:24+01:00Marco Riccisoftware@the13thletter.info
<pre>* concurrency-audit:
Document the results of the concurrency audit
Lock the derivepassphrase CLI against concurrent updating
Lock derivepassphrase internals against concurrent updating
GitHub: Closes #22.
</pre>
tag:gitlist.org,2012:commit/77e030e7f8bbefea236a0a0a1682efb558fe0225Document the results of the concurrency audit2025-03-13T13:17:03+01:00Marco Riccisoftware@the13thletter.info
<pre></pre>