Recent commits to derivepassphrase.git (de8a116ceb0a86a13c38266088eedb5f53713d91)

Make the notes instruction text and marker translatable

2025-01-23T10:51:36+01:00

The instruction text for editing notes is natural language text, and
should therefore be translated, but was overlooked when determining
translatable messages.

To ensure that the instruction text and the marker cannot be mismatched,
the marker is translated separately and inserted verbatim after the
instruction text.
</pre>

Merge topic branch 'code-cleanup' into master

2025-01-22T16:46:06+01:00

* t/code-cleanup:
  Fix improper use of `assert_never`
  Fix outdated test config specification
  Refactor pytest fixtures concerning SSH agent spawning
  Refactor vault config validity checking and falsy value cleanup functions
  Check at runtime if deprecated keyword arguments are used
</pre>

Fix improper use of `assert_never`

2025-01-21T21:02:31+01:00

</pre>

Fix outdated test config specification

2025-01-21T21:02:31+01:00

The set of "consistently testable vault configurations" is determined by
a specific settings to the validator function.  The validator function
no longer accepts the `allow_derivepassphrase_extensions` keyword
parameter, but the vault test config selection logic was not yet updated
to reflect this.
</pre>

Refactor pytest fixtures concerning SSH agent spawning

2025-01-21T21:02:31+01:00

The two pytest fixtures `running_ssh_agent` and `spawn_ssh_agent` both
deal with providing access to SSH agents, spawning them if necessary.
They differ in the data they provide to the test functions (just the
environment setup, or an actual connected `SSHAgentClient`) and in their
parametrization (`running_ssh_agent` spawns any one, `spawn_ssh_agent`
spawns all).  However, despite the spawning logic being basically
identical, both methods contained incompatible implementations of the
logic, separately for named agent spawning and for system agent
spawning.

So, consolidate these functions into a single spawning function, and
move all necessary supporting code (context manager for subprocess
termination, typing protocol for spawn function) to the top level.
</pre>

Refactor vault config validity checking and falsy value cleanup functions

2025-01-21T21:02:31+01:00

Introduce a new workhorse class that provides the validity checking and
the falsy value cleanup functionality.  The existing top-level functions
are now mere facades.  The primary reason is to keep the complexity and
the nesting level of these functions low-ish: they still trigger linting
errors that need to be silenced, but the nesting is tamer, and some
common functionality (e.g., tree traversal) can be usefully extracted.
</pre>

Check at runtime if deprecated keyword arguments are used

2025-01-21T21:02:31+01:00

The `warnings.deprecated` decorator sadly does not do anything at
runtime if merely one of several overloads is deprecated.  And it seems
to fail even if the deprecated signature is actively used; see
`_types.is_vault_config`.  Implement a known working solution to check
if the deprecated keyword argument was supplied.

(No tests yet, so excluded from coverage.)
</pre>

Merge topic branch 'pathlib' into master

2025-01-20T18:00:28+01:00

* t/pathlib:
  Use `pathlib` for path or filename operations
</pre>

Use `pathlib` for path or filename operations

2025-01-20T18:00:12+01:00

The interface was already supported by all the user-facing code
(interestingly enough) and by almost all of the internal code.  Using
`pathlib.Path` objects directly instead of manually dealing with string
or byte string collections does cut down on a lot of the otherwise
explicit bookkeeping and context management.

Some changes to the tests are necessary because other (or more)
functions need to be mocked, or other ways of testing successful or
ensuring unsuccessful operations are needed.
</pre>

Merge topic branch 'documentation-fixes' into master

2025-01-20T15:27:30+01:00

* t/documentation-fixes:
  Make `T_Buffer` type variable visible at runtime again
  Adapt "storeroom" tests to use new names for helper functions
</pre>