Recent commits to derivepassphrase.git (e109f3ac7c5c09b89816405e3ebc9dd195685024)

Upgrade ruff to 0.6, and redo configuration and rule selection

2024-09-01T10:22:13+02:00

hatch currently still defaults to ruff 0.4.5, which includes some
now-deprecated rules and lacks some others.  Furthermore, hatch's
default configuration for ruff is very opinionated and not explained
anywhere.  Upgrading the ruleset to 0.6 still incurs the overhead of
having to look at every single new ruff rule, determining whether it
fits the hatch configuration, and allowing it.  This is a similar amount
of effort to enabling all of ruffs rules and deciding, based on the
flagged violations, whether a rule or rule category is worth keeping.

This has now been implemented: almost all rules are now selected, and
the exceptions are documented in the project settings.  (ruff actually
includes documentation on linting rules that tend to get violated if
ruff is also used for reformatting.)  hatch is configured to use ruff
0.6 and this user configuration, ignoring its own default ruff
configuration.  Some further ruff settings are necessary, e.g. adapting
the default copyright text template to match hatch's copyright text
template, as is one new mypy setting (the "ignore-without-code" error).

Note: the new ruleset has not actually been applied to the codebase yet,
because the effect would be spread out across the codebase, and we
expect multiple topic branches to be merged soon.
</pre>

Undo single-child hatch environment inheritance

2024-08-24T14:45:41+02:00

The "types" and "hatch-static-analysis" hatch environments, which were
supposed to both inherit from a common base environment, behave somewhat
differently: the former needs dependent packages installed (so
`extra-dependencies = [..., "pytest", ...]`, `skip-install = false` and
perhaps even `features = [...]`), while the latter doesn't
(`skip-install = true`, `extra-dependencies` and `features` are empty).
Of course, neither tool needs the other installed either.  As such,
there is very little content left for an actual common base environment.
So, fold all settings from the base environment into the "types"
environment, and remove the base environment and the inheritance.
</pre>

Specify project dependencies more clearly and explicitly

2024-08-17T01:09:23+02:00

Use proper syntax for dependency version specification (spaces, and
compatible release operator).  If sensible, add a comment as to why we
have this dependency, and why at that version.  Furthermore, for hatch
environments, make use of environment inheritance, and move the
dependencies to the correct environments instead of collecting them all
in the "dev" extra.
</pre>

Sort sections in pyproject.toml

2024-08-17T00:52:02+02:00

</pre>

Merge topic branch 'issue4-improve-common-error-messages' into master

2024-08-16T17:12:56+02:00

* t/issue4-improve-common-error-messages:
  Add Changelog entry for error message/handling revision
  Add missing tests for reworked error message handling
  Fix error message capitalization
  Fix error bubbling in outdated test
  Add a specific error class and codes for SSH agent failures
  Document and handle other errors passed through to the command-line interface
  Use better error message handling in the command-line interface

GitHub: Closes #4.
</pre>

Add Changelog entry for error message/handling revision

2024-08-16T17:12:38+02:00

</pre>

Add missing tests for reworked error message handling

2024-08-16T16:31:24+02:00

Add missing tests for the revised error messages/classes and error
handling code due to a1763e8b5dedbf123856a79ddb0e8395cddd6f88 and
5c6045e10ca9c8b56432711dec5efb98b5892d55.
</pre>

Fix error message capitalization

2024-08-16T16:21:45+02:00

We still use error messages with non-sentence case at multiple places,
particularly messages like "no valid SSH key selected".
</pre>

Fix error bubbling in outdated test

2024-08-16T16:19:56+02:00

In
`tests.test_derivepassphrase_cli:test_230a_config_directory_not_a_file`,
we assumed that a `FileExistsError` while storing the configuration file
would bubble all the way up to the test harness.  This isn't the case
anymore, because of a1763e8b5dedbf123856a79ddb0e8395cddd6f88 and
5c6045e10ca9c8b56432711dec5efb98b5892d55... but we actually forgot to
update the call to use the new wrapper from
5c6045e10ca9c8b56432711dec5efb98b5892d55.
</pre>

Add a specific error class and codes for SSH agent failures

2024-08-16T13:27:20+02:00

Add the generic `SSH_AGENT_FAILURE` and `SSH_AGENT_SUCCESS` status codes
(as `_types.SSH_AGENT.FAILURE` and `_types.SSH_AGENT.SUCCESS`,
respectively), and add an `SSHAgentFailedError` class to signal error
returns from the SSH agent. The error class may emit a specific or
a generic error message, depending on the status code and error message
passed.

Rewrite the tests to use actual failure status codes, instead of random
magic numbers. Rewrite it further to deal with the `_types.SSH_AGENT`
enum instead of numeric codes. This also makes the tests more readable.
</pre>