https://git.schokokeks.org/derivepassphrase.git/tree/ea42999f28cba570fc5954628bea71998cd7692a Recent commits feed provided by GitList. In particular, pay consideration to interfaced agents, not just spawned ones. https://git.schokokeks.org/derivepassphrase.git/commit/ea42999f28cba570fc5954628bea71998cd7692a software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 18:42:06 +0100 ea42999f28cba570fc5954628bea71998cd7692a When reacting to failures uploading a test key into an agent, both the agent type `KnownSSHAgent.UNIXPageant` and the type `KnownSSHAgent.Pageant` should be treated the same. However, the `ssh_agent_client_with_loaded_test_keys` only treated the former agent type specially. Now it also treats the latter type the same. https://git.schokokeks.org/derivepassphrase.git/commit/d63d93b230f23dbbfbb2eff0209cb3d076980b42 software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 18:26:50 +0100 d63d93b230f23dbbfbb2eff0209cb3d076980b42 Instead of iterating over all test keys and testing whether the agent is not isolated and the key is a successfully loaded key, first check whether the agent is isolated or not, *then* iterate over the successfully loaded key names and extract the relevant test key from the test key table. The efficiency per operation is similar, but the previous setup always iterated the whole test key table unconditionally, whereas the new setup only iterates the successfully loaded key name set (fewer entries than the test key table), and only conditionally. https://git.schokokeks.org/derivepassphrase.git/commit/ff4e9ae1d2b3291b9606c270c8b03404307e045a software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 17:33:06 +0100 ff4e9ae1d2b3291b9606c270c8b03404307e045a Add docstrings to the `_prepare_payload` and `_load_key_optimistically` helper functions. Also change the signature of `_load_key_optimistically` to take the test key structure directly, instead of taking a (dict) key to lookup the structure. (These types of things become apparent when writing docstrings, even for otherwise internal functions.) https://git.schokokeks.org/derivepassphrase.git/commit/02be2f8d25e96969ea375b67c34a01d2daf9c1b3 software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 17:19:38 +0100 02be2f8d25e96969ea375b67c34a01d2daf9c1b3 https://git.schokokeks.org/derivepassphrase.git/commit/8f2c55735196b72cb4e305c53c14973c39048b8e software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 17:10:07 +0100 8f2c55735196b72cb4e305c53c14973c39048b8e The function is now called `_load_key_optimistically`, and returns a success indication whether the key was (potentially already) loaded or not. Also, the private key blob cannot be `None` anymore, so the function no longer has degenerate cases. https://git.schokokeks.org/derivepassphrase.git/commit/e0d33502c7d14a7114acef43bf237f0b81cc556a software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 17:01:22 +0100 e0d33502c7d14a7114acef43bf237f0b81cc556a https://git.schokokeks.org/derivepassphrase.git/commit/942785aa31a0964b2377013b803a37f631f6e980 software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 15:15:35 +0100 942785aa31a0964b2377013b803a37f631f6e980 Extract the `_prepare_payload` and the `_load_keys_optimistically` helper functions from the `ssh_agent_client_with_test_keys_loaded` fixture function. The `_load_keys_optimistically` helper function needs further refactoring into a per-key function, not a per-keyset function; to be added in a following commit. https://git.schokokeks.org/derivepassphrase.git/commit/dabdc29b8128104b53c3b8a89176e46e3d371cf5 software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 15:09:33 +0100 dabdc29b8128104b53c3b8a89176e46e3d371cf5 The `ssh_agent_client_with_test_keys_loaded` fixture function is due to be split, moving the upload bits and the `prepare_payload` function to new top-level helper functions. Rename the `prepare_payload` function, and add parameter definitions so that the extracted functions will make immediate sense. https://git.schokokeks.org/derivepassphrase.git/commit/fe1d7014afb71b37021a538d9581403b7d8bdab0 software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 14:57:17 +0100 fe1d7014afb71b37021a538d9581403b7d8bdab0 The old implementation did not record *which* trailing data we were seeing, on the grounds that well-behaved SSH agents would not send any trailing data anyway (i.e., that this error condition was a failsafe). However, while implementing Windows named pipe support, I observed Pageant sporadically returning malformed responses that trigger this error. Without actually recording the trailing data, it is hard to understand whether this is Pageant's fault (unlikely) or ours (more likely), and specifically, whether we're implementing the protocol incorrectly (unlikely), or rather the communication channel (much more likely). So the `TrailingDataError` class now optionally records the actual raw response and the trailing data portion that caused the error, to aid debugging. https://git.schokokeks.org/derivepassphrase.git/commit/837e1f69087b3fd5e343ca83615c5d7cb1760e66 software@the13thletter.info (Marco Ricci) Sat, 27 Dec 2025 14:43:35 +0100 837e1f69087b3fd5e343ca83615c5d7cb1760e66