https://git.schokokeks.org/derivepassphrase.git/tree/febfd09916cde8d5e47a26a3cad8a11176d758db Recent commits feed provided by GitList. https://git.schokokeks.org/derivepassphrase.git/commit/febfd09916cde8d5e47a26a3cad8a11176d758db software@the13thletter.info (Marco Ricci) Sun, 16 Mar 2025 23:50:53 +0100 febfd09916cde8d5e47a26a3cad8a11176d758db * The "interactive input" replacement value for the `WarnMsgTemplate.PASSPHRASE_NOT_NORMALIZED` message is now translatable. The previous form was quirky and too clever, and probably only worked in languages with similar grammar and sentence structure. * The `Label.DERIVEPASSPHRASE_VAULT_REPEAT_HELP_TEXT` message was wrong due to an off-by-one error. * The `Label.DERIVEPASSPHRASE_VAULT_PRINT_NOTES_BEFORE_HELP_TEXT` message should reference the service metavar, not the term "service" itself. * The default notes placeholder text when using the vault legacy editor interface is very wordy, and incited at least one test user to delete it character by character before entering the new notes. A shorter placeholder text will hopefully achieve the same effect in less keystrokes. * Several verb tense and punctuation mistakes were corrected. https://git.schokokeks.org/derivepassphrase.git/commit/b127dd363ce8ad0ad26e88c31200dc5c3736f8b4 software@the13thletter.info (Marco Ricci) Sun, 16 Mar 2025 23:13:47 +0100 b127dd363ce8ad0ad26e88c31200dc5c3736f8b4 https://git.schokokeks.org/derivepassphrase.git/commit/6372560fd2c27a91c55769659a1748a0cc3ca5d1 software@the13thletter.info (Marco Ricci) Sun, 16 Mar 2025 13:33:37 +0100 6372560fd2c27a91c55769659a1748a0cc3ca5d1 * vault-cli-objectification: Reimplement the `vault` CLI as methods of a context object https://git.schokokeks.org/derivepassphrase.git/commit/cd3c72db9b6457dc6757effa209693ce10dd4dbd software@the13thletter.info (Marco Ricci) Sun, 16 Mar 2025 13:23:38 +0100 cd3c72db9b6457dc6757effa209693ce10dd4dbd Introduce a "vault context" object holding the associated data for the call to the `derivepassphrase vault` CLI, and implement the actual CLI as a collection of methods on this object. The "vault context" object mostly just wraps the click context object and encodes the dispatch table for the CLI operations. The main advantage of this modelling is the much smaller size per, and lower cyclomatic complexity of, each CLI operation. As an implementation detail, the old implementation of the `get_user_config` inner function's error handling branch for `OSError` had coverage testing purely by accident, because `get_user_config` was being called unconditionally, very early in the CLI control flow. The refactored CLI however reads the user configuration only as needed for the specific operation. So this error handling branch needs a new, separate test. As a further implementation detail, the `is_param_set` inner function no longer caches its result, because it is now an object method: `functools.cache` explicitly documents that adding a cache to object methods causes a circular reference between the cache and the object via the `self` parameter. Given the actual contents of this function, there appears to be little point in working around this memory issue just to outfit an already cheap operation (a single `Mapping.get` call) with a cache. As yet another further implementation detail, checking for misleading passphrases should work even if the passed configuration snippet is not technically a `dict`, but rather a `Mapping`. Finally, due to the vault context object now wrapping the click context, it is possible (and sensible) to wrap the logging calls into methods of the vault context object so that less out-of-bounds information needs to be passed to the logger explicitly at the call site. https://git.schokokeks.org/derivepassphrase.git/commit/7261f505d57249ef54b8c66a30efb57890ba70a7 software@the13thletter.info (Marco Ricci) Sun, 16 Mar 2025 13:23:05 +0100 7261f505d57249ef54b8c66a30efb57890ba70a7 * hatch-test-matrix: Add PyPy 3.11 to the test matrix https://git.schokokeks.org/derivepassphrase.git/commit/47e3b46d01ffffe4a24ec7e73f4c0833fa0e4ca0 software@the13thletter.info (Marco Ricci) Thu, 13 Mar 2025 13:32:54 +0100 47e3b46d01ffffe4a24ec7e73f4c0833fa0e4ca0 https://git.schokokeks.org/derivepassphrase.git/commit/af40d3b552a6dec8b42833ecc2dfd32c8894f76e software@the13thletter.info (Marco Ricci) Thu, 13 Mar 2025 13:21:20 +0100 af40d3b552a6dec8b42833ecc2dfd32c8894f76e * concurrency-audit: Document the results of the concurrency audit Lock the derivepassphrase CLI against concurrent updating Lock derivepassphrase internals against concurrent updating GitHub: Closes #22. https://git.schokokeks.org/derivepassphrase.git/commit/a4ad05723414662d9df1607034c5dd7d646f1b49 software@the13thletter.info (Marco Ricci) Thu, 13 Mar 2025 13:18:24 +0100 a4ad05723414662d9df1607034c5dd7d646f1b49 https://git.schokokeks.org/derivepassphrase.git/commit/77e030e7f8bbefea236a0a0a1682efb558fe0225 software@the13thletter.info (Marco Ricci) Thu, 13 Mar 2025 13:17:03 +0100 77e030e7f8bbefea236a0a0a1682efb558fe0225 In a very coarse manner, after command-line parsing, detect whether the CLI operation is a read-write operation or a read-only one, and if it is read-write, run the whole operation while holding a lock. The lock is held on a temporary file whose basename is dependent on the full path to the `derivepassphrase` configuration directory. The file is stored in the system temporary directory if possible, and will be synchronized using `msvcrt.locking` or `fcntl.flock`, whichever is appropriate. Coverage checking for the Windows-specific application code is disabled because we have no Windows runners for the test suite. The test suite itself merely adds tests for the temporary directory function, but is otherwise unchanged. https://git.schokokeks.org/derivepassphrase.git/commit/78e5b9a8cc2bbb89f353e2bbec41da405c5b0ad2 software@the13thletter.info (Marco Ricci) Sun, 02 Mar 2025 16:27:06 +0100 78e5b9a8cc2bbb89f353e2bbec41da405c5b0ad2