möglicherweise undefinierte Variablen abgefangen
Bernd Wurst

Bernd Wurst commited on 2018-06-26 13:48:00
Zeige 1 geänderte Dateien mit 7 Einfügungen und 7 Löschungen.

... ...
@@ -97,7 +97,7 @@ if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete') {
97 97
     $c['country'] = verify_input_general(maybe_null(strtoupper($_REQUEST['land'])));
98 98
     $c['zip'] = verify_input_general(maybe_null($_REQUEST['plz']));
99 99
     $c['city'] = verify_input_general(maybe_null($_REQUEST['ort']));
100
-    if ($new) {
100
+    if ($new && isset($_REQUEST['email'])) {
101 101
         $c['email'] = verify_input_general(maybe_null($_REQUEST['email']));
102 102
         if (!check_emailaddr($c['email'])) {
103 103
             system_failure("Ungültige E-Mail-Adresse!");
... ...
@@ -105,7 +105,7 @@ if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete') {
105 105
     }
106 106
         
107 107
 
108
-    if ($_REQUEST['telefon']) {
108
+    if (isset($_REQUEST['telefon']) && $_REQUEST['telefon'] != '') {
109 109
         $num = format_number(verify_input_general($_REQUEST['telefon']), $_REQUEST['land']);
110 110
         if ($num) {
111 111
             $c['phone'] = $num;
... ...
@@ -115,7 +115,7 @@ if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete') {
115 115
     } else {
116 116
         $c['phone'] = NULL;
117 117
     }
118
-    if ($_REQUEST['mobile']) {
118
+    if (isset($_REQUEST['mobile']) && $_REQUEST['mobile'] != '') {
119 119
         $num = format_number(verify_input_general($_REQUEST['mobile']), $_REQUEST['land']);
120 120
         if ($num) {
121 121
             $c['mobile'] = $num;
... ...
@@ -125,7 +125,7 @@ if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete') {
125 125
     } else {
126 126
         $c['mobile'] = NULL;
127 127
     }
128
-    if ($_REQUEST['telefax']) {
128
+    if (isset($_REQUEST['telefax']) && $_REQUEST['telefax'] != '') {
129 129
         $num = format_number(verify_input_general($_REQUEST['telefax']), $_REQUEST['land']);
130 130
         if ($num) {
131 131
             $c['fax'] = $num;
... ...
@@ -161,14 +161,14 @@ if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete') {
161 161
             warning('Zur Verwendung als Domaininhaber fehlen noch Angaben.');
162 162
             redirect('edit?id='.$_REQUEST['id'].'&back='.$_REQUEST['back'].'&domainholder=1');
163 163
         }
164
-        if (!have_mailaddress($_REQUEST['email'])) {
164
+        if (isset($_REQUEST['email']) && !have_mailaddress($_REQUEST['email'])) {
165 165
             warning("Die neu angelegte Adresse kann erst dann als Domaininhaber genutzt werden, wenn die E-Mail-Adresse bestätigt wurde.");
166 166
         }
167 167
     }
168 168
 
169 169
     $domains = domainlist_by_contact($c);
170 170
     if ($domains) {
171
-        if ($c['email'] != $_REQUEST['email'] && !(isset($_REQUEST['designated']) && $_REQUEST['designated'] == 'yes')) {
171
+        if (isset($_REQUEST['email']) && $c['email'] != $_REQUEST['email'] && !(isset($_REQUEST['designated']) && $_REQUEST['designated'] == 'yes')) {
172 172
             system_failure("Sie müssen die explizite Zustimmung des Domaininhabers bestätigen um diese Änderungen zu speichern.");
173 173
         }
174 174
     }
... ...
@@ -181,7 +181,7 @@ if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete') {
181 181
     $id = save_contact($c);
182 182
     $c['id'] = $id;
183 183
 
184
-    if ($new || $c['email'] != $_REQUEST['email']) {
184
+    if (isset($_REQUEST['email']) && ($new || $c['email'] != $_REQUEST['email'])) {
185 185
         if (have_mailaddress($_REQUEST['email'])) {
186 186
             save_emailaddress($c['id'], verify_input_general($_REQUEST['email']));
187 187
         } else {
188 188